@emaste since you're doing :freebsd: patches...

reviews.freebsd.org/D38047

😃

I've got 3 in total that I am trying to get in in time for 14.1 . 2 of which have been open for > 6 months

@david Can you please generate diffs for Phabricator with context, e.g. via `git show -U99999` or `git diff -U99999` - it is awkward to review otherwise. There's also quite a lot in this diff -- in general it's better to have one logical change per review to make it easier to review.

What are the other two?

Follow

@emaste It is one logical change; it is allowing NSCD to respond to getgrouplist(3). but that is an entirely different 'kind' of call (the way NSCD is structured is around 'database' and 'key' and 'method'. So if you have database 'group' and key 'name' and method 'name lookup', well, that is 'get group entry by name'. In this case the 'name' isn't the group name, it is a user name, and the response isn't a group entry, but a list of groups.

· · Web · 0 · 0 · 0
Sign in to participate in the conversation
Cross Family's Mastodon

The social network of the future: No ads, no corporate surveillance, ethical design, and decentralization! Own your data with Mastodon!